Skip to content

[Utils] Expand is_match #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

[Utils] Expand is_match #416

merged 1 commit into from
Aug 15, 2025

Conversation

kylesayrs
Copy link
Contributor

Purpose

  • Make module matching in vLLM a little cleaner

Changes

  • Change function signature of is_match to the following:
def is_match(
    name: str,
    module: torch.nn.Module,
    targets: str | Iterable[str],
    ignore: str | Iterable[str] = tuple(),
    fused: Optional[FusedMappping] = None,
)

Testing

  • Matching tests pass

@kylesayrs
expand is_match
2131de3 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs changed the title [Utils] [Utils] Expand is_match Aug 9, 2025
brian-dellabetta
brian-dellabetta reviewed Aug 11, 2025
View reviewed changes
shanjiaz
shanjiaz approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@shanjiaz shanjiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kylesayrs kylesayrs merged commit 8a93d26 into main Aug 15, 2025
1 check passed
@kylesayrs kylesayrs deleted the kylesayrs/matching-expand-is-match branch August 15, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@shanjiaz shanjiaz shanjiaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylesayrs @brian-dellabetta @shanjiaz